search

AccelerationNet / cl-csv

A common lisp library providing easy csv reading and writing
Other
116 stars 22 forks source link

warnings about implicit generic functions #9

Closed tpapp closed 11 years ago

tpapp commented 11 years ago

This is a cosmetic issue: SBCL warns about

Unknown location: style-warning: Implicitly creating new generic function CL-CSV:FORMAT-CSV-VALUE.

Unknown location: style-warning: Implicitly creating new generic function CL-CSV:WRITE-CSV-VALUE.

I was about to submit a patch inserting two defgeneric's, but then I realized that I don' t understand why these are generic functions, especially write-csv-value.

ryepup commented 11 years ago

I believe these are methods to support extensibility. If I wanted to, I could pass complex objects to write-csv in my list of rows, and then specialize write-csv-value to write out the part I wanted. I'm not sure if anyone actually does that anywhere, but that was probably the intent.

bobbysmith007 commented 11 years ago

As ryepup says they are generic for extensibility purposes.

I have patched to make there be some defgenerics