Friendlier to invalid arithmetic expressions - Githubissues

Accelergy-Project / accelergy

Accelergy is an energy estimation infrastructure for accelerator energy estimations

http://accelergy.mit.edu

MIT License

124 stars 40 forks source link

Friendlier to invalid arithmetic expressions #13

Closed tanner-andrulis closed 2 years ago

tanner-andrulis commented 2 years ago

My last pull request introduced the following problems:

Invalid arithmetic expressions are reported multiple times when propagated different places
Invalid arithmetic expressions are not populated in node attributes

The latter caused problems because string expressions like "32nm" and "1ns" are invalid arithmetic expressions and would be skipped.

Both are skipped now:

On invalid expression, a WARN is printed and the string value is propogated
WARN is only printed once per invalid expression