search

Accelergy-Project / processing-in-memory-design

24 stars 5 forks source link

wrong num_destination for D2A_NoC #5

Closed deepanshu761999 closed 7 months ago

deepanshu761999 commented 2 years ago

In line number 29, I think it should be "action_share: num_destinations". Also, it appears that D2A_NoC is between shared_glb and dummy buffer. But then, wouldn't the "num_destinations" be 1 always? so, D2A_converter's convert action is invoked only once per input? @nellie-wu

Screenshot from 2022-04-06 04-27-27 also, action_share of DAC_SimpleMulticast seems to have no effect on energy( check ERT yaml ) Screenshot from 2022-04-13 04-06-04

nellie-wu commented 2 years ago

Thanks for pointing out the problems! We are looking into it and will get back with new updates.