Accenture / AmpliGraph

Python library for Representation Learning on Knowledge Graphs https://docs.ampligraph.org
Apache License 2.0
2.14k stars 251 forks source link

Define a model name for saved models #71

Closed pyvandenbussche closed 5 years ago

pyvandenbussche commented 5 years ago

Background and Context Currently, using the save_model() function in model_utils, will always result in a pickled file named 'model.pickle'. This is very limiting when you perform multiple experiments.

Description Why not adding a new argument to the function with a custom made name? The current name can be used as default but I would rather suggest a name with the creation time included to avoid loosing previously saved models and to give more context to users who did not specify a name.

chanlevan commented 5 years ago

@pyvandenbussche Thanks for your helpful suggestion. The code has been updated. Now the model can be saved with customised name or with default option with timestamp.