Accenture / OSDU-Ontology

An ontology designed for oil and gas, and subsurface energy data based on the industry standards.
Apache License 2.0
18 stars 7 forks source link

property naming convention #10

Closed VladimirAlexiev closed 1 year ago

VladimirAlexiev commented 1 year ago

There are many properties that don't conform to the lowerCamelCase convention, eg:

totalcostamount
costcurrency
VladimirAlexiev commented 1 year ago

Furthermore, some properties are in plural, eg

agreementIDs
businessActivities

But all props should be in singular (in RDF, any property may have multiple values, and yet each value is a single object).

VladimirAlexiev commented 1 year ago

The problem with lowercased props is more serious: All prop names are lowercased (mistyped) in Restrictions, and therefore don't match the declared property names. For example:

osdu:Cost rdf:type owl:Class ;
    rdfs:subClassOf [
        a owl:Restriction ;
        owl:onProperty osdu:totalcostamount ;
        owl:minCardinality "1"^^xsd:nonNegativeInteger ;
    ] ;
osdu:totalCostAmount rdf:type owl:DatatypeProperty ;

There are 413 matches for "owl:onProperty" and all are lowercased. I'd say more than 50% are wrong, eg all these:

    111:        owl:onProperty osdu:parameterkindid ;
    139:        owl:onProperty osdu:persistablereferencecrs ;
    205:        owl:onProperty osdu:datasetproperties ;
    216:        owl:onProperty osdu:facettypeid ;
    221:        owl:onProperty osdu:facetroleid ;
ana-tudor commented 1 year ago

Hi Vladimir - thanks for this important catch. We have corrected camelcasing usage, have fixed inconsistent naming in the restrictions, and have removed pluralization in property naming to the best of our abilities.