search

Accenture / adop-platform-management

Apache License 2.0
60 stars 60 forks source link

Support embedded cartridges #16

Closed kramos closed 7 years ago

kramos commented 8 years ago

Pom files don't get their own repo. Perhaps Cartridges don't always need on either. How about the cartridge loader goes a recursive find for the first metadata.cartridge file and it finds and treats that as the cartridge root?

Happy to implement but only if you'll accept this.

I recognise I will need to think about avoiding the repo getting loaded twice (once as the local copy of the cartridge and once if someone re-states it in the urls.txt file).

anton-kasperovich commented 8 years ago

I like the idea, don't see much value to sync and keep all cartridges by default in my Gerrit 👍

anton-kasperovich commented 8 years ago

@SachinKSingh28 @nickdgriffin what do you think guys?

kramos commented 8 years ago

Created a PR: #18

kramos commented 7 years ago

PR #18 was accepted, this is done!