search

Accenture / adop-platform-management

Apache License 2.0
60 stars 60 forks source link

Adding OVERWRITE_REPOS flag to Load Cartridge job. #17

Closed michael-t-dukes closed 8 years ago

michael-t-dukes commented 8 years ago

This will stop repositories being overwritten by default for every cartridge load.

The scenario that it fixes is the following:

Tested several scenarios: Test1 - creating project to test groovy

test1 - creating project to test groovy

Test2 - performing load without tick box on new project

test2 - performing load without tick box on new project proof2 - cartridge loaded successfully

Test3a - Adding commit into repository

test3a - adding comment

Test3b - Loading cartridge unticked

test3b - loading cartridge unticked proof3b - commit still exists proof3b - loaded cartridge

Test4 - Loading cartridge ticked

test4 - loading cartridge ticked proof4 - commit overwritten

Test5 - Loading cartridge from beginning on new project ticked

test5 - loading cartridge from begginign on new project ticked proof5 - repos exist
michael-t-dukes commented 8 years ago

resolve #13

SachinKSingh28 commented 8 years ago

Change looks good and I've tested it as well. I believe this would require a change in CLI command as well (anyways that would be a separate PR for adop-docker-compose repository).