search

Accenture / adop-platform-management

Apache License 2.0
60 stars 60 forks source link

Updated Load_Platform_Extension to support multiple instances #19

Open aliciasteen opened 8 years ago

aliciasteen commented 8 years ago

Updated the load_platform_extension to support creation of multiple instances to work as it does with one instance

nickdgriffin commented 8 years ago

Hello!

Thanks for the PR for this, I have a couple of cosmetic tweaks please:

I think we need to have a think about the Nginx handling at the end as if there are multiple hosts we don't know which one should be proxied, so I think it'd make sense for the template to contain an output that states the IP that should be used - the job can then lift that to do the replace in "ec2-extension.conf". @dsingh07 - what do you think?

Thanks, Nick

dsingh07 commented 8 years ago

Hi @aliciasteen @nickdgriffin

Currently the Nginx handling will work in a way such that if the file exists, it will look for a variable called INSTANCE_ID, which in the case of two instances will be in a list.

So yes, I agree that the template should contain an output of the IP that needs to be proxied. This may mean we need to rewrite some of our existing platform extensions (i.e sample and Chef) to give this output.

Thanks, Dharmanshu

aliciasteen commented 8 years ago

Have updated the split lines and echo instanceIDs

aliciasteen commented 8 years ago

Updated changes ready to merge