Closed dsingh07 closed 7 years ago
Thanks for the review @nickdgriffin
I have fixed that bug now.
Waiting for this PR to get merged in: https://github.com/dsingh07/adop-platform-management/pull/1 to my branch, and this PR should be in a reviewable state again.
There have been changes introduced by @BuleGeorge and @RobertNorthard which will be tested by me, after rebasing with all the other changes that have been introduced.
I shall update this PR with exciting developments :)
Thanks for the quick review @RobertNorthard
Have made those changes that you've requested.
Thanks @dsingh07.
@nickdgriffin @anton-kasperovich this requires one final look over (fresh pair of eyes) before we merge.
Commits have been squashed and is ready for a final round of testing from @nickdgriffin and @anton-kasperovich :)
Thanks @dsingh07 added a few comments in relation to error handling. After this PR is merged, we should also merge https://github.com/Accenture/adop-cartridge-skeleton/pull/3 to demonstrate how to use the pluggable library.
LGTM. Thanks everyone for the hard work.
@dsingh07 @nickdgriffin @anton-kasperovich @BuleGeorge @SachinKSingh28 @MarisBahtins @IrmantasM
This pull request will update miscellaneous platform jobs to support Pluggable SCM:
Test Scenarios
As the build label is also set to !master the above tests should also confirm we can run the cartridge loader from unix/linux based slaves.
For all tests it is expected the respective repositories captured in urls.txt will be created with the respective SCM provider (Gerrit, BitBucket)
This PR is dependent on:
https://github.com/Accenture/adop-jenkins/pull/29https://github.com/Accenture/adop-docker-compose/pull/187https://github.com/Accenture/adop-pluggable-scm/pull/4