search

Access4Learning / sif3-framework-dotnet

SIF 3.0 Developer Framework for .NET
Apache License 2.0
14 stars 19 forks source link

Removed duplicated code from GenericConsumer #1

Closed aranm closed 9 years ago

aranm commented 10 years ago

There was a lot of duplicated code in the GenericConsumer class related to logging. I pulled it into a single method for the following reasons:

  1. The code was duplicated.
  2. I think a customisable logger should be able to be used. I don't think the framework should have a dependency on a particular logger, you should be able to use any you choose to. If the logger is only referenced once in the file it would make this easier to implement.
rafidzal commented 9 years ago

A more generic solution to logging is currently being investigated which will deprecated this pull request. As such, this pull request will be closed.

A new develop branch has also been created for making future pull requests against.