search

Access4LearningNA / NADM

North American Data Model
2 stars 2 forks source link

Use explicit names for counts in StudentAttendanceSummary #110

Closed mattharris5 closed 8 years ago

mattharris5 commented 8 years ago

The community review 3.4 model has daysAbsent and daysTardy but then excusedAbsences and unexcusedAbsences. It's ambiguous whether we are referring to excused days or excused periods, so we should use an explicit and consistent name pattern for these fields.

vinceparedes commented 8 years ago

I think we can always improve on the names of elements. There are a lot of people who are concerned with backward compatibility, even from 2.7 to 3. This object is currently a copy from 2.7 moved to 3. The description of the object does make clear that the summary is with respect to daily attendance and not period attendance.

On the other hand, this object is new for 3.4 and if we are going to make changes, now is the time. Also, there are way too many elements that are required. This is a holdover from when we designed to very narrow use cases.

mattharris5 commented 8 years ago

It came up on the @Access4Learning/natb call today and I offered to submit the issue. It would probably be OK if the elements remained unchanged, but as you point out it's a good time to make the element names align semantically.