search

Access4LearningNA / specgen_input_na

Where we define the Unity data model.
Apache License 2.0
0 stars 0 forks source link

P-POD: Add [Prefix]ShareWithObjectType throughout. #148

Closed 4pins closed 3 years ago

4pins commented 3 years ago

Wherever RefId appears: ShareWithObjecType, DoNotShareWithObjecType, and NeverShareWithObjecType.

LindaNSIP commented 3 years ago

RefId_Object element added as a string for each place

4pins commented 3 years ago

Ensure spelling is correct, check for two T's.

4pins commented 3 years ago

Names coppied and pasted from the draft: ShareWithRefId_Object, DoNotShareWithRefId_Object, NeverShareWithRefId_Object

4pins commented 3 years ago

After back and forth wound up here (results currently being shared with the AU contingent):

Resolve to send (to all interested parties and the NATB) the following text to the ITB as feedback and implementation in the PPod:

The proposed names are actively misleading.

PermissionGranteeObjectRefId PermissionGranteeRefId_object

It suggests that the data element has both a refId and the object data including the refId.

I suggest a more informative alternative.

PermissionGranteeRefId PermissionGranteeObjectTypeName

The phrase 'PermissionGrantee' serves to group the two elements.

PermissionGranteeRefId is a normal SIF thing and makes sense here.

The phrase 'PermissionGranteeObjectTypeName' indicates to a programmer that the phrase is a string that says what the type is.

The other elements with this patter, eg, ContactForRequests, should be changed to follow this pattern.

The Location element should be entirely replaced with new elements that follow this pattern.

4pins commented 3 years ago

In place. We don't expect any further push back.