search

Access4all / adg

Accessibility Developer Guide
http://www.accessibility-developer-guide.com
Other
183 stars 34 forks source link

Fix search error #345

Closed backflip closed 3 years ago

backflip commented 3 years ago

As reported by Alex in Slack, searching for aria does not work as it shows no results and an error is thrown (TypeError: Cannot read property 'length' of undefined).

SiteSearch might have updated their API. Until we get a new vendor script, this quick workaround seems to solve this specific issue.

backflip commented 3 years ago

@ralf57, feel free to reopen this issue if you'd prefer another approach (e.g. updating the vendor script).

ralf57 commented 3 years ago

@backflip thanks for the fix. However I suggest that you put a comment above the edited line since we might need to apply the change again when we update the sitesearch360-v12.js which is originally provided by SS360.

backflip commented 3 years ago

@ralf57, here you go: https://github.com/Access4all/adg/pull/346