search

Access4all / adg

Accessibility Developer Guide
http://www.accessibility-developer-guide.com
Other
187 stars 36 forks source link

ADG-353 Add rel attribute to footer links #354

Closed christophdubach closed 3 years ago

christophdubach commented 3 years ago

I added the rel="noopener noreferrer" attribute to the footer links with target="_blank" to prevent reverse tabnabbing attacks and get rid of the Trust and Safety: Links to cross-origin destinations are unsafe Lighthouse errors. See https://web.dev/external-anchors-use-rel-noopener/

Closes #353

christophdubach commented 3 years ago

@backflip, as René mentions in his comment https://github.com/Access4all/adg/issues/353#issuecomment-869159320, it could make sense to handle the addition of the rel="noopener noreferrer" attribute to links with target="_blank" in the build tasks.

backflip commented 3 years ago

@christophdubach, hm, I don't think we have any of those. Or do we add the target attribute automagically?

christophdubach commented 3 years ago

@backflip, I don’t know. So let’s add it manually for the moment.