search

Access4all / adg

Accessibility Developer Guide
http://www.accessibility-developer-guide.com
Other
187 stars 36 forks source link

ADG-260 Remove background color motion, improve text color contrast #355

Closed christophdubach closed 3 years ago

backflip commented 3 years ago

Personally, I kinda miss the scroll animation, but I support this change anyway. :) The improved contrast is great.

renestalder commented 3 years ago

I like it too. Do we need some more people to have a look at it? I guess this solves all the issues mentioned in the referenced issue, thus for me this looks resolved with the PR.

The mix of SCSS variables and CSS custom properties seems weird, but I suppose it was already like that overall in the code before your change.

christophdubach commented 3 years ago

You are right, @renestalder. I replaced some of the SCSS vars with CSS custom properties.

christophdubach commented 3 years ago

I added too many semicolons – so you have to review this PR once again, sorry @renestalder! 🤦🏼‍♂️