search

Access4all / adg

Accessibility Developer Guide
http://www.accessibility-developer-guide.com
Other
183 stars 34 forks source link

ADG-363 Inline SVG during build #368

Closed backflip closed 1 year ago

backflip commented 3 years ago

This change allows us to inline SVG files into HTML via a new handlebars helper (as discussed in https://github.com/Access4all/adg/pull/364#discussion_r668566194).

backflip commented 3 years ago

@Franco-zfa, could you have a look at whether the logo on https://60ed7cd3d5eb33000811425e--accessibility-developer-guide.netlify.app is accessible? It contains an SVG with ADG logo as title.

Franco-zfa commented 3 years ago

Works fine form e

Von: Thomas Jaggi @.> Gesendet: Dienstag, 13. Juli 2021 13:50 An: Access4all/adg @.> Cc: Franco D'Elia @.>; Mention @.> Betreff: Re: [Access4all/adg] ADG-363 Inline SVG during build (#368)

@Franco-zfahttps://github.com/Franco-zfa, could you have a look at whether the logo on https://60ed7cd3d5eb33000811425e--accessibility-developer-guide.netlify.app is accessible? It contains an SVG with ADG logo as title.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Access4all/adg/pull/368#issuecomment-879020519, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATLJXVVZ4EMSI6F7FWDKIGLTXQR6XANCNFSM5AIVF7DQ.

backflip commented 3 years ago

@Franco-zfa, thanks a lot!

backflip commented 3 years ago

@christophdubach, could you check whether this breaks anything from https://github.com/Access4all/adg/pull/364?

backflip commented 2 years ago

Friendly reminder, @christophdubach and @renestalder