Access4all / adg

Accessibility Developer Guide
http://www.accessibility-developer-guide.com
Other
183 stars 34 forks source link

chore: bump node to 14 #394

Closed backflip closed 1 year ago

backflip commented 1 year ago

This PR updates the Node version from 12 to 14 as 12 is no longer supported (see https://nodejs.dev/en/about/releases/ for currently supported versions).

An update to Node 16 will require updates to dependencies, so I will do that in a separate step.

netlify[bot] commented 1 year ago

Deploy Preview for accessibility-developer-guide ready!

Name Link
Latest commit
Latest deploy log https://app.netlify.com/sites/accessibility-developer-guide/deploys/64511761f23db900b483e0f6
Deploy Preview https://deploy-preview-394--accessibility-developer-guide.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

backflip commented 1 year ago

Deployment without cache was successful: https://deploy-preview-394--accessibility-developer-guide.netlify.app/

Build logs: https://app.netlify.com/sites/accessibility-developer-guide/deploys/64511761f23db900b483e0f6

christophdubach commented 1 year ago

At first I was not able to build. I always got the error message Error: Can't find Python executable "python", you can set the PYTHON env variable (macOS 13.3, Apple M1 Pro).

Node 14 seems to require a Python version that was not installed on my machine. I had to go through the following steps, after which it worked:

arch -arm64 brew install pyenv
arch -arm64 pyenv install 2.7.18
pyenv local 2.7.18
export PATH="${HOME}/.pyenv/shims:${PATH}"
backflip commented 1 year ago

@christophdubach, interesting, I will keep an eye on this! I'm planning on updating the whole thing to 18 soon, will be interesting to see whether this persists for you.