search

Access4all / adg

Accessibility Developer Guide
http://www.accessibility-developer-guide.com
Other
183 stars 34 forks source link

chore: make image resize task cross-platform compatible #396

Closed backflip closed 1 year ago

backflip commented 1 year ago

The gulp plugin we are currently using for resizing images does different path rewrites on Unix and Windows, creating images in the wrong location on the latter system

While removing the jimp wrapper plugin with jimp itself, I discovered that sharp provided better speed (twice as fast) and a more intuitive API.

NOTE: As sharp requires Node >= 14, this PR is based on https://github.com/Access4all/adg/pull/394 which should be merged first.

netlify[bot] commented 1 year ago

Deploy Preview for accessibility-developer-guide ready!

Name Link
Latest commit 38c1d3fceab85d9581aa506cdd793500f8eceaab
Latest deploy log https://app.netlify.com/sites/accessibility-developer-guide/deploys/64535ca6c01a6a000944c39d
Deploy Preview https://deploy-preview-396--accessibility-developer-guide.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.