chore: windows path issues

Access4all / adg

Accessibility Developer Guide

http://www.accessibility-developer-guide.com

Other

183 stars 34 forks source link

Closed backflip closed 1 year ago

backflip commented 1 year ago

Due to incompatibilities with \ when building the HTML, there were issues with the navigation and the theme when running the process on Windows. Specifically, the navigation was not properly nested as parent pages were not detected by path, and the theme class on the body was invalid.
The formatting scripts did not properly run as the file paths were incorrectly quoted on Windows. When fixing this I stumbled upon the need for a endOfLine setting for prettier in order to prevent Windows from reformatting everything.

netlify[bot] commented 1 year ago

Name	Link
Latest commit	b1b0778d87c2f84c0842779ce2c6e73bf3dbdbd7
Latest deploy log	https://app.netlify.com/sites/accessibility-developer-guide/deploys/6464feb27996c90008afe2d3
Deploy Preview	https://deploy-preview-408--accessibility-developer-guide.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

backflip commented 1 year ago

@NicSR, this should fix your issues. I'll give you an update after this was merged so you can rest on the main branch locally.

christophdubach commented 1 year ago

@backflip: On my Mac everything runs fine. But I don’t think there’s a way to test the Windows path issue on a Mac?

backflip commented 1 year ago

@christophdubach, if it still runs on your Mac, too, I probably did not break too much. So this is perfect, thanks for checking!