search

Access4all / adg

Accessibility Developer Guide
http://www.accessibility-developer-guide.com
Other
183 stars 34 forks source link

Removed unneccessary page scroll #410

Closed reemhamz closed 1 year ago

reemhamz commented 1 year ago

There was a scroll on the page that wasn't meant to be there -- it would scroll a few pixels and stop. This got in the way of the main scroll, and was causing a cumbersome experience throughout the website.

Here's what it looked like: Screenshot 2023-05-30 at 1 56 23 PM

I've removed the overflow-x: hidden; rule from the html property in CSS, and that seemed to have worked. I haven't noticed any unusual bugs or side effects once I removed that, so kindly let me know if you spot one.

netlify[bot] commented 1 year ago

Deploy Preview for accessibility-developer-guide ready!

Name Link
Latest commit 4207f7564747d07ea5083edc18949b5abdcddb9a
Latest deploy log https://app.netlify.com/sites/accessibility-developer-guide/deploys/6475748c8203570008ce066b
Deploy Preview https://deploy-preview-410--accessibility-developer-guide.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

backflip commented 1 year ago

@reemhamz, thanks a lot for this! As I'm unable to reproduce this when visiting https://www.accessibility-developer-guide.com/introduction/ in the latest Firefox, Chrome or Safari on the latest macOS: Would you mind sharing some additional information? Any chance this could be some kind of extension inserting something into our site, for example?

christophdubach commented 1 year ago

@reemhamz: I am not able to reproduce this behaviour. At least not with Safari, Chrome and Firefox on macOS - not even with forced scrollbar visibility.

With which browser on which operating system do you encounter this display error with the two scrollbars?

reemhamz commented 1 year ago

@backflip @christophdubach Thanks for getting back to me! I noticed the error whilst running Firefox on macOS. However, I decided to cross-browser test based on your comments, and it seems like no other browser is experiencing the strange scroll, not even my Firefox Nightly browser. I think you're right @backflip to suggest that it may be an extension injecting itself into the page. Strange, I've personally never encountered an extension behaving that way, but I do recall an older forum suggesting this as a bug w/ some extensions. Thanks for taking a look, folks. I'll close the PR since it was a bug on an individual-basis and nothing to do with your code.

backflip commented 1 year ago

@reemhamz, thanks for checking!