AccessKit / accesskit

Accessibility infrastructure for UI toolkits
https://accesskit.dev
BSD 3-Clause "New" or "Revised" License
1.05k stars 53 forks source link

winit: Don't treat `accesskit_unix` as a feature #426

Closed waywardmonkeys closed 3 months ago

waywardmonkeys commented 4 months ago

We don't need to check both for a feature (enabled by default) and the various target_os values.

As a result, the accesskit_unix dependency is no longer optional on the Unix platforms.

waywardmonkeys commented 4 months ago

I'm on macOS, so I couldn't test this locally myself.

DataTriny commented 4 months ago

We added this feature because some projects (namely Bevy) didn't want to enable the Unix adapter by default, see #214. Given the fact that the situation didn't change much, I am not willing to reconsider this right now.

Could you please clarify your intention in submitting this PR @waywardmonkeys?

waywardmonkeys commented 3 months ago

I was incorrectly fixing something that triggers an error in 2024 edition ... I'll do a correct fix in the future!