search

Accessible360 / accessible-slick

the last (accessible) carousel you'll ever need.
https://accessible360.github.io/accessible-slick
MIT License
254 stars 45 forks source link

Console log test messages should be removed. #60

Closed EmmanuelZamudioTR closed 2 years ago

EmmanuelZamudioTR commented 2 years ago

There are some console.log('test') messages that should be removed, because those are popping out in our site.

There are some logs like this on slick.js: image

christopherdarling commented 2 years ago

@EmmanuelZamudioTR Are you sure you're using the latest bundle? I can't find this in the source code

EmmanuelZamudioTR commented 2 years ago

@EmmanuelZamudioTR Are you sure you're using the latest bundle? I can't find this in the source code

It's not on master branch, it's on the latest release tag v1.0.1, so I think you'll need to launch another one with the last master updates.

Here it is: image

christopherdarling commented 2 years ago

should be resolved by https://github.com/Accessible360/accessible-slick/issues/48 then

EmmanuelZamudioTR commented 2 years ago

should be resolved by #48 then

Do you have a tentative date for your next release?

christopherdarling commented 2 years ago

I don't own this repo, just helping out in some of the bug reports.

pratikbassi commented 2 years ago

Fix merged into master, will be in the next minor release

cojaco commented 1 year ago

Is it planned to remove the console.log messages also from the npm package?