Accessible360 / accessible-slick

the last (accessible) carousel you'll ever need.
https://accessible360.github.io/accessible-slick
MIT License
254 stars 45 forks source link

Added aria-label for prev,next arrow and slick dots #62

Closed sumitWebDev closed 2 years ago

mikemccaffrey commented 2 years ago

Is there a reason you need the aria-label other than for screen readers, since those labels are already available in the slick-sr-only elements.

sumitWebDev commented 2 years ago

Thanks for your response. I did not notice the slick-sr. It's fine and we do not require to add aria label.

sumitWebDev commented 2 years ago

Hi Mike,

Thanks for your response. I did not notice the slick-sr. It's fine and we do not require to add aria label.

Thanks and Regards, Sumit

On Fri, May 13, 2022 at 1:29 AM Mike McCaffrey @.***> wrote:

Is there a reason you need the aria-label other than for screen readers, since those labels are already available in the slick-sr-only elements.

— Reply to this email directly, view it on GitHub https://github.com/Accessible360/accessible-slick/pull/62#issuecomment-1125371740, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFUIRGTLHZGQV3U5BMFWUKDVJVPJNANCNFSM5UME72TA . You are receiving this because you authored the thread.Message ID: @.***>