search

AccessibleForAll / AccessibleWebDev

A resource for developers wanting to learn the basics of accessibility
https://accessibleweb.dev
MIT License
174 stars 96 forks source link

Footer links - "become a contributor" and "support us" are not opening in new tab/new window #341

Closed SatyamSetia closed 1 year ago

SatyamSetia commented 1 year ago

Describe the bug Specifically 2 links in the footer - "Become a contributor" and "Support us" have open in new tab icon beside the text and aria-label="open in new window" as well but clicking these links opens the target url in same tab.

To Reproduce Observe the links in app footer. OR Try using a screen reader, it announces these link as "open in new window" but it gets open in same tab.

Expected behaviour "Become a contributor" and "Support us" should open in new tab.

Screenshots

Screenshot 2023-07-08 at 12 47 31 PM
SatyamSetia commented 1 year ago

Hey, @EmmaDawsonDev Just wanted to share my interest on working this bug fix if in-case you find it to be a relevant issue to be fixed.

My proposal for the fix - Using "target" attribute on these 2 anchor tags

EmmaDawsonDev commented 1 year ago

Hi Satyam, well spotted! These links are actually not meant to open in a new window, I must've missed asking the previous contributor to remove the icons. Please feel free to remove the icons.

SatyamSetia commented 1 year ago

Acknowledged 👍

SatyamSetia commented 1 year ago

Hey, @EmmaDawsonDev I have raised a PR for fixing this issue. Please find the changes here - https://github.com/AccessibleForAll/AccessibleWebDev/pull/342 Requesting your review whenever you get time.