AccessibleForAll / AccessibleWebDev

A resource for developers wanting to learn the basics of accessibility
https://accessibleweb.dev
MIT License
172 stars 95 forks source link

Maintainer image load size can be reduced #354

Closed SaptarshiSarkar12 closed 1 year ago

SaptarshiSarkar12 commented 1 year ago

Is your feature request related to a problem? Please describe. The maintainer's Image is loaded at the default size 460 x 460 which is not required and is causing a high image load size. Hence, it will take longer time to load the website on devices with a poor network connection.

Describe the solution you'd like The maintainer's image should be loaded at the size of the container by appending &s=[size of the image required] to the GitHub avatar URL.

Additional context For @EmmaDawsonDev's GitHub 120 x 120 profile picture, the link will be https://avatars.githubusercontent.com/u/57045550?v=4&s=120. For @ctoffanin's GitHub 120 x 120 profile picture, the link will be https://avatars.githubusercontent.com/u/1682188?v=4&s=120

This will reduce the image load size by about 90%. Reference : https://github.com/nyancodeid/quotes/issues/71#issue-1015935234

github-actions[bot] commented 1 year ago

Hello @SaptarshiSarkar12, thanks for raising an issue in this project. The maintainers of this project are volunteers so please be understanding if it takes time before you get a response. We still appreciate your help with raising issues!

SaptarshiSarkar12 commented 1 year ago

If the issue looks good, can I work on this?

EmmaDawsonDev commented 1 year ago

Sure! Thanks for spotting it!

SaptarshiSarkar12 commented 1 year ago

Sure! Thanks for spotting it!

Thank you @EmmaDawsonDev !

SaptarshiSarkar12 commented 1 year ago

@EmmaDawsonDev I have created a PR #355, please review it.