search

AccessibleForAll / AccessibleWebDev

A resource for developers wanting to learn the basics of accessibility
https://accessibleweb.dev
MIT License
172 stars 95 forks source link

Footer GitHub icon opens in the same tab #360

Closed MuhammadRabi closed 1 year ago

MuhammadRabi commented 1 year ago

Describe the bug The Footer GitHub icon opens in the same tab.

To Reproduce Steps to reproduce the behavior:

  1. Go to the Homepage
  2. Scroll down to the Footer
  3. Click on GitHub Icon

Expected behavior external links should be opened in a new tab

Screenshots N.A.

Additional context I would like to work on this if allowed

github-actions[bot] commented 1 year ago

Hello @MuhammadRabi, thanks for raising an issue in this project. The maintainers of this project are volunteers so please be understanding if it takes time before you get a response. We still appreciate your help with raising issues!

EmmaDawsonDev commented 1 year ago

Hi Muhammad, the link actually behaves as expected. Opening in a new tab/window is not the inbuilt expected behaviour and can cause screen reader users and people with cognitive impairments to get disoriented by the behaviour. As it is, it's possible for people to right click and choose to open in a new tab if they wish.

MuhammadRabi commented 1 year ago

Hi Emma, I didn't know that. I will close the issue then. Thank you!