AccessibleForAll / AccessibleWebDev

A resource for developers wanting to learn the basics of accessibility
https://accessibleweb.dev
MIT License
172 stars 95 forks source link

Fixed #365 i added scroll-margin-top:5rem to global.css file #366

Closed 2div closed 1 year ago

2div commented 1 year ago

Describe your changes

h2, h3, h4, h5, h6 { margin: 1rem 0 0 0; scroll-margin-top: 5rem; // i added this line to fix the issue }

Screenshots - If Any (Optional)

Link to issue

Closes #365

Checklist before requesting a review

github-actions[bot] commented 1 year ago

Hello @2div, thanks for raising a pull request in this project. The maintainers of this project are volunteers so please be understanding if it takes time before you get a response. We still appreciate your help with creating pull requests!

2div commented 1 year ago

The scroll margin top works great. However, please revert the changes to the package-lock file and the yarn.lock file. As there were no changes made to these files they don't need to be included in the PR. As soon as they are reverted then this is ready to merge.

Thank you for your feedback. Can you please explain what you mean by revert the changes to the package-lock file and the yarn.lock file. I do not think i changed or edited these files. I only edit the global CSS file.

May i know what and how to revert these changes you mentioned so that we can do merg ?

EmmaDawsonDev commented 1 year ago

Sure. These files are created when you do npm install or yarn install. And then if you use the command git add . then it will add them to the commit even though you didn’t make changes to them. That’s why the contributing files suggest using git add name-of-file instead because it’s safer. But it’s no problem as almost everything with git can be undone.

First go to your branch and in the terminal you want to type git revert commit-hash which in this case is git revert 0a99424. You should then be able to do ‘git add styles/globals.css’ and commit and push. That should automatically update this pull request

2div commented 1 year ago

Sure. These files are created when you do npm install or yarn install. And then if you use the command git add . then it will add them to the commit even though you didn’t make changes to them. That’s why the contributing files suggest using git add name-of-file instead because it’s safer. But it’s no problem as almost everything with git can be undone.

First go to your branch and in the terminal you want to type git revert commit-hash which in this case is git revert 0a99424. You should then be able to do ‘git add styles/globals.css’ and commit and push. That should automatically update this pull request

Thank you for your explanation this topic to me. I did not know about it but now i learned from you. I did git revert 0a99424`. then ‘git add styles/globals.css’

I request re-review but i am not sure if that the right thing because its my first time see change requested to PR Should i do new PR ? please advise me. Thank you

EmmaDawsonDev commented 1 year ago

Great, now the two extra files are gone. For some reason it didn't keep the change that you made to the styles file. If you can add the margin-scroll-top back in and then do git add styles/globals.css again and then commit and push it should be ready to merge. No need to do a new PR, everything you update in your branch will appear here as soon as you push it.

2div commented 1 year ago

Great, now the two extra files are gone. For some reason it didn't keep the change that you made to the styles file. If you can add the margin-scroll-top back in and then do git add styles/globals.css again and then commit and push it should be ready to merge. No need to do a new PR, everything you update in your branch will appear here as soon as you push it.

Ok , I followed the steps and pushed again. Than you