AccessibleForAll / AccessibleWebDev

A resource for developers wanting to learn the basics of accessibility
https://accessibleweb.dev
MIT License
172 stars 95 forks source link

added puncuation #369

Closed itolimaesther closed 10 months ago

itolimaesther commented 1 year ago

Describe your changes

I added punctuation(support,) to the sentence "An empty alt attribute has the most wide-spread support so that should be your go-to choice when using icons." for better readability.

Screenshots - If Any (Optional)

Link to issue

Closes #367

Checklist before requesting a review

github-actions[bot] commented 1 year ago

Hello @itolimaesther, thanks for raising a pull request in this project. The maintainers of this project are volunteers so please be understanding if it takes time before you get a response. We still appreciate your help with creating pull requests!

itolimaesther commented 1 year ago

@EmmaDawsonDev please review this PR.

itolimaesther commented 11 months ago

Alright.

itolimaesther commented 11 months ago

@EmmaDawsonDev will I need to create another PR?

Though I can't see a way to do that.

EmmaDawsonDev commented 11 months ago

No, you should just be able to make the changes and push them and they will be reflected here.

itolimaesther commented 11 months ago

I have made some code changes, removed the prettier formatter, and also added content for the link. Please check and let me know if the issue persists.

itolimaesther commented 11 months ago

Alright. I have seen all your comments. I make the corrections and I will make a push again.

EmmaDawsonDev commented 10 months ago

I'm going to merge this into a temporary branch and fix the issues when I get time. Thanks so much for your help so far :)

itolimaesther commented 10 months ago

I apologize for finishing with this. I have been down for some time. Please let me know if there are anything I need to add.

EmmaDawsonDev commented 9 months ago

No worries. I fully understand that life gets in the way sometimes.