feat: add Touch Target Minimum sections to Links and Button pages - Githubissues

AccessibleForAll / AccessibleWebDev

A resource for developers wanting to learn the basics of accessibility

https://accessibleweb.dev

MIT License

172 stars 95 forks source link

feat: add Touch Target Minimum sections to Links and Button pages #391

Closed CBID2 closed 7 months ago

CBID2 commented 7 months ago

Describe your changes

This is an improved version of PR #390. Read the Description section for context.

Screenshots - If Any (Optional)

Link to issue

Closes #386

Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] Followed the repository's Contributing Guidelines.
[ ] I ran the app and tested it locally to verify that it works as expected.
[ ] I have checked my code with an automatic accessibility tool such as Axe Dev Tools or Wave and it shows no errors.
Additional Information (Optional)

N/A

CBID2 commented 7 months ago

The text looks good. Are you able to move the text up so it's above the WCAG criteria section in both cases? If not, let me know and I'll fix it on my side.

Hey @EmmaDawsonDev. No, it'll be harder to do on the app

EmmaDawsonDev commented 7 months ago

No worries, I can merge it in and fix it.