search

AcclimateContainer / acclimate-container

Adapters for PHP framework containers to an interoperable interface
MIT License
220 stars 16 forks source link

Added Phalcon DI Container Adapter #10

Closed theluk closed 8 years ago

theluk commented 9 years ago

One issue in this commit is, that as Phalcon cannot be just installed using composer, as it needs to be compiled, I made the tests skippable if phalcon is not present using the following comment

/**
 * @requires extension phalcon
 */

That produces three S (skipped) in the command line test runner. I have not found a nicer method.

jeremeamia commented 9 years ago

There are a few style things and one bug that I'd like you to fix up, but otherwise, it looks good. Thanks. :smile:

theluk commented 9 years ago

will fix it next week

jeremeamia commented 9 years ago

@theluk Hey, it's been a while. I have some time to look at this, so if you'd like to go ahead and clean this up, I'll pull it in. Thanks.

jeremeamia commented 8 years ago

@theluk still interested in fixing this up? Seems like a decent addition.

Sam-Burns commented 8 years ago

I recommend closure in favour of https://github.com/jeremeamia/acclimate-container/pull/27 , which is still active.

Sam-Burns commented 8 years ago

Closed in favour of https://github.com/jeremeamia/acclimate-container/pull/27 , which is still active.