search

AcclimateContainer / acclimate-container

Adapters for PHP framework containers to an interoperable interface
MIT License
220 stars 16 forks source link

Added Njasm DIC Adapter #7

Closed njasm closed 10 years ago

njasm commented 10 years ago

Added Njasm DIC Adapter. Added Njasm Adapter Test. Added Njasm package to composer.json Added Njasm Container github link to README.md

jeremeamia commented 10 years ago

It looks like your njasm container already implements the container-interop ContainerInterface. That means there isn't a really need for it to be "acclimated", right?

njasm commented 10 years ago

yes. My bad, when i've checked your project. I've taught on creating an adapter so my own container be supported out of the box as a sub-container.

As I see it, without an adapter, my container is ready to be used with your CompositeContainer. Confirm?

jeremeamia commented 10 years ago

Feel free to double check that it actually works, but it should work with the other parts of Acclimate without an adapter, because it implements the ContainerInterface.

njasm commented 10 years ago

ok, cool thanks for the fast reply. gonna check that!

njasm commented 10 years ago

@jeremeamia i've tested my container with CompositeContainer and I confirm that it does not need adapters to work as expected.

I'll close this pull request.. there's no need for an adapter. my bad.