Accord-Project / aec3po

AEC3PO: Architecture, Engineering, Construction Compliance Checking and Permitting Ontology
https://w3id.org/lbd/aec3po/
2 stars 1 forks source link

hasTarget hasValue #106

Open beachtom opened 6 months ago

beachtom commented 6 months ago

As hasTarget and hasValue can either be data or object properties this causes us issues elsewhere.

My suggestion approach

  1. Rename hasTarget to hasLinkedTarget
  2. Create a new data property called hasTarget - should be a string bool or nuber
  3. Create a new object by property (similar to hasLinkedTarget) called hasLinkedValue

Happy to discuss on naming etc.....

maximelefrancois86 commented 6 months ago

In the ontology at least it is clear:

I understand you mean: they are both used sometimes as object properties, sometimes as data properties ?

We could also reuse the typical naming convention as in SSN and BOT:

beachtom commented 6 months ago

Yes this makes sense - I am happy with these names

hasSimpleXXX is the data properties?

maximelefrancois86 commented 6 months ago

yes

beachtom commented 6 months ago

Fab @AmnaKRDB @EdliraK are you OK to make the changes if you agree?

beachtom commented 6 months ago

Hi all - having a discussion with Passi and Vladamir at the end of the day will have a new proposal here - will post shortly.

beachtom commented 6 months ago
  1. What is currently hasTarget be renamed to hasBSDDTarget
  2. Create a new object property hasNestedTarget the range of which should be a CheckMethod
  3. Can we rename hasComparator to hasOperator
  4. Create a new property called hasTarget - which is a datatype property (string, number, bool)
  5. Create a new property called hasBSDDValue - which is an object property
  6. Create a new property called hasNestedValue which has domain CheckMethod
EdliraK commented 6 months ago

Done: What is currently hasTarget be renamed to hasBSDDTarget Create a new object property hasNestedTarget the range of which should be a CheckMethod Create a new property called hasBSDDValue - which is an object property Create a new property called hasNestedValue which has domain CheckMethod

Pending: Can we rename hasComparator to hasOperator

Create a new property called hasTarget - which is a datatype property (string, number, bool) I created hasTarget as string. Do you need one for each type?

beachtom commented 6 months ago
  1. Yes let's rename it back.
  2. Ideally string number and bool properties
maximelefrancois86 commented 6 months ago

Watch out, there is:

hasOperator in https://github.com/Accord-Project/aec3po/blob/main/src/check_method.ttl#L177-L182 , also in https://github.com/Accord-Project/aec3po/blob/main/src/vocabularies/check_method_operators.ttl#L176-L182

hasComparator in https://github.com/Accord-Project/aec3po/blob/main/src/vocabularies/check_method_comparators.ttl#L115-L122

We may just want to move the definition of one term from a module to another (and change rdfs:isDefinedBy metadata)