Open beachtom opened 7 months ago
In the ontology at least it is clear:
I understand you mean: they are both used sometimes as object properties, sometimes as data properties ?
We could also reuse the typical naming convention as in SSN and BOT:
Yes this makes sense - I am happy with these names
hasSimpleXXX is the data properties?
yes
Fab @AmnaKRDB @EdliraK are you OK to make the changes if you agree?
Hi all - having a discussion with Passi and Vladamir at the end of the day will have a new proposal here - will post shortly.
Done: What is currently hasTarget be renamed to hasBSDDTarget Create a new object property hasNestedTarget the range of which should be a CheckMethod Create a new property called hasBSDDValue - which is an object property Create a new property called hasNestedValue which has domain CheckMethod
Pending: Can we rename hasComparator to hasOperator
Create a new property called hasTarget - which is a datatype property (string, number, bool) I created hasTarget as string. Do you need one for each type?
Watch out, there is:
hasOperator in https://github.com/Accord-Project/aec3po/blob/main/src/check_method.ttl#L177-L182 , also in https://github.com/Accord-Project/aec3po/blob/main/src/vocabularies/check_method_operators.ttl#L176-L182
hasComparator in https://github.com/Accord-Project/aec3po/blob/main/src/vocabularies/check_method_comparators.ttl#L115-L122
We may just want to move the definition of one term from a module to another (and change rdfs:isDefinedBy metadata)
As hasTarget and hasValue can either be data or object properties this causes us issues elsewhere.
My suggestion approach
Happy to discuss on naming etc.....