search

Accord-Project / aec3po

AEC3PO: Architecture, Engineering, Construction Compliance Checking and Permitting Ontology
https://w3id.org/lbd/aec3po/
2 stars 1 forks source link

RASEDecomposedStatement #66

Closed beachtom closed 11 months ago

beachtom commented 1 year ago

RASEDecomposedStatement does not seem to be required - and can be removed

AmnaKRDB commented 1 year ago

In fact, it has been defined as a subclass of Statement. So, any RASE-tagged statement (RequirementStatement, ApplicationStatement, etc.) can be directly defined as Statement. I think @maximelefrancois86 means by RASEDecomposedStatement the whole RASE block/statement, which could be later divided into sub-statements (, , , ).

beachtom commented 1 year ago

hmm - in any case it is kindof an anti-pattern to what the rest of the clauses are doing so I suggest removal

maximelefrancois86 commented 1 year ago

The idea of this class was to capture also what is not tagged R A S or E.

It's maybe not useful to explicit this class in your datasets, but it may prove useful for reasoning purposes. Can we state this instead of delete?

beachtom commented 1 year ago

Hi - OK.

I am just not seeing the use case for this right now?

maximelefrancois86 commented 11 months ago

Apparently commit https://github.com/Accord-Project/aec3po/commit/419d3863e433f264eb3a3ddedd916ab348edb58d commented out the class RASEDecomposedStatement.

This commit should have referred to this issue, or a comment in this issue should refer to that commit.

At least, the job should be done completely, commenting out lines 41, 57, 73, 89, in this same file.

beachtom commented 11 months ago

Would suggest completely removing this I do not think it is needed

maximelefrancois86 commented 11 months ago

If the PR is fine with you, please approve it, we'll merge, and this will close this issue automatically