Application vs Applicabilities

Accord-Project / aec3po

AEC3PO: Architecture, Engineering, Construction Compliance Checking and Permitting Ontology

https://w3id.org/lbd/aec3po/

2 stars 1 forks source link

Application vs Applicabilities #8

Closed VladimirAlexiev closed 1 year ago

VladimirAlexiev commented 1 year ago

The class is defined as "Application" but referenced as "Applicabilities": it should be "Applicability" everywhere. Misspelling a class name is not ok.

(the rest applies to multiple rdfs:comment)

a. Commas are missing,
b. Space is missing after ),
c. R and S are written in singular, but A and E are written in plural.

https://github.com/Accord-Project/aec3po/blob/5fb6f7e2b8b9f0f208caeeab68461aa8b3c0dfcd/src/aec3po.ttl#L175-L178

VladimirAlexiev commented 1 year ago

In the documenation it was https://w3id.org/lbd/aec3po/Appliances "Represents the Appliances tag in the semantic mark-up RASE..."

beachtom commented 1 year ago

It should be Application in my view

VladimirAlexiev commented 1 year ago

Agreed, it's even in the logo of Nick's company: https://linkedbuildingdata.net/ldac2023/files/presentations/industry2/LDAC2023-Presentation-NN.pdf

maximelefrancois86 commented 1 year ago

solved in commit f5555ec