search

AccordGroup / MandrillSwiftMailerBundle

A Symfony bundle that provides a Swiftmailer transport service for Mandrill
GNU General Public License v2.0
20 stars 15 forks source link

Fix service name #7

Closed gonzalovilaseca closed 9 years ago

gonzalovilaseca commented 9 years ago

I couldn't make this bundle work out of the box due to Symfony swift mailer bundle that has this in it's extension class:

 $container->setAlias(sprintf('swiftmailer.mailer.%s.transport', $name), sprintf('swiftmailer.mailer.transport.%s', $transport));

So this PR fixes the naming issue.

Kyoushu commented 9 years ago

Hi @gonzalovilaseca, I'm looking into this now. I'll be correcting a few naming mistakes I've made with variables in the extension class, so I won't merge your pull request straight away.

I also want to write a test which ensures it works with a kernel containing only the framework, swiftmailer, and mandrill extensions.

Kyoushu commented 9 years ago

I've manually applied your changes as part of my work on improving tests for the bundle. As soon as the build for the latest commit on master passes, I'll create a new release and close the pull request.

Thank you for the feedback :)

Kyoushu commented 9 years ago

All good

https://travis-ci.org/AccordGroup/MandrillSwiftMailerBundle/builds/56607758

Closing the pull request, thanks again.