AccordGroup / MandrillSwiftMailerBundle

A Symfony bundle that provides a Swiftmailer transport service for Mandrill
GNU General Public License v2.0
20 stars 15 forks source link

Please separate logic from framework wrapping #9

Closed RemiWoler closed 9 years ago

RemiWoler commented 9 years ago

As this seems to be the most complete and maintained library for this functionally, I believe it would be helpful to separate the logic into a framework-agnostic library, which the Symfony2 bundle could depend on. For Symfony2, this will provide the same functionality because of Composer (the bundle can require the lib), while for every other framework the library now becomes available to use, without the (unneeded) Symfony2 wrapping.

verschoof commented 9 years ago

:+1:

Kyoushu commented 9 years ago

I've been thinking about doing this for a while. I'll try to get started on it this week and keep you updated.

verschoof commented 9 years ago

Well, if you make a new branch we can do some PR's? :)

Kyoushu commented 9 years ago

A new repo will be made to contain just the transport and related tests. This will be under the namespace Accord\MandrillSwiftMailer.

The existing class Accord\MandrillSwiftMailerBundle\SwiftMailer\MandrillTransport will effectively become a proxy for the transport loaded from the new repo. This will ensure BC compatibility for people using the bundle just for the transport class, if there are any.

This update will be released as 1.2.0 when it's done, so I've created the branch 1.2.x-dev.

Kyoushu commented 9 years ago

I'll also annotate the old transport as deprecated

jrattue commented 9 years ago

:+1:

Kyoushu commented 9 years ago

The standalone transport can now be found here, it's also registered in Packagist. I've also taken the opportunity to shore up the unit tests.

https://github.com/AccordGroup/MandrillSwiftMailer

I'll create a 1.0.0 release for the library when the 1.2.x-dev branch is ready to be merged back into master.

Kyoushu commented 9 years ago

All done, 1.2.0 released

verschoof commented 9 years ago

Good job!

RemiWoler commented 9 years ago

Awesome work! This is much appreciated!