search

Accounting-Companion / TallyConnector

You can use Tally Connector to Connect your desktop/Mobile Applications with Tally seamlessly.
47 stars 29 forks source link

Possible typo error? TallyConnector/Tally.cs#L327 #10

Closed zeevy closed 3 years ago

zeevy commented 3 years ago

https://github.com/Accounting-Companion/TallyConnector/blob/master/TallyConnector/Tally.cs#L327

"EmployeeGroupsXml" instead of "EmployeeesXml"

saivineeth100 commented 3 years ago

tnq @zeevy for corrections I already worked on that function, In todays commit that will be resolved I changed that whole function and spitted to separate functions so that we can only query single masters(if required) instead of querying all masters

zeevy commented 3 years ago

Incase you have not fixed it already, these both fields seems to be interchanged in "Company.cs" model

        [XmlElement(ElementName = "BOOKSFROM")]
        public string StartingFrom { get; set; }

        [XmlElement(ElementName = "STARTINGFROM")]
        public string BooksFrom { get; set; }
saivineeth100 commented 3 years ago

Incase you have not fixed it already, these both fields seems to be interchanged in "Company.cs" model

        [XmlElement(ElementName = "BOOKSFROM")]
        public string StartingFrom { get; set; }

        [XmlElement(ElementName = "STARTINGFROM")]
        public string BooksFrom { get; set; }

Not Fixed Will Fix now