search

Accruent / robotframework-zoomba

Extended Robot Framework libraries to make testing GUI, REST/SOAP API, Mobile, and Windows Desktop easier.
https://accruent.github.io/robotframework-zoomba/
Apache License 2.0
143 stars 35 forks source link

Alternative Error Handling #355

Closed aljcalandra closed 1 year ago

aljcalandra commented 1 year ago
coveralls commented 1 year ago

Coverage Status

coverage: 100.0%. remained the same when pulling 31745ea057868c29e0b5a4f108bd9d2db8855f8c on aljcalandra:alternative_error_handling into 756730adcfb56dedc85017fcc740e1d23a4352e2 on Accruent:master.

aljcalandra commented 1 year ago

Is there anything that can be done for the failing tests or is this issue caused elsewhere?

Wolfe1 commented 1 year ago
  1. Thanks for the pull request long time no see ♥
  2. That Edge test is just flakiness, not sure about the "generate_report" job either just thats just broken it looks like.
  3. The chrome tests are actual "failures" caused by the code change (They passed today for a dependabot update from Robotframework). Since the error messages changed in your pull request, the expected values for those tests need to be modified to match.
aljcalandra commented 1 year ago

Oof just saw the response, I'll go through and fix that up when I get a chance

Oh also, fun stuff, w3schools has different css for edge vs chrome.

aljcalandra commented 1 year ago

The token used for the generate_report job does not have write permissions for issues/pullrequests so I think it'll fail until that gets updated. Alternatively it might be worth looking into the replacing it with the summary action.

Wolfe1 commented 1 year ago

Appreciate the effort, thanks!