search

Accuity / rspec-puppet-utils

MIT License
23 stars 8 forks source link

Puppet 4 support? #9

Open fatmcgav opened 7 years ago

fatmcgav commented 7 years ago

Are there any plans to add support for Puppet 4?

As I've got some tests that work perfectly on Puppet 3.x using rspec-puppet-utils MockFunction, but they don't work on Puppet 4.x. From what I can see, the MockFunction's just aren't being fired...

TomPoulton commented 7 years ago

Hi @fatmcgav, yep I plan to support Puppet 4 at some point soon once we migrate ourselves.

In the meantime, if you find any more issues (and if you have any ideas why they're happening), drop them on this thread

alexjfisher commented 7 years ago

@TomPoulton I'm guessing puppet 4 is supported now (at least partially)? But... is it possible to use MockFunction with newer puppet 4 api namespaced functions? Perhaps I'm just not getting the syntax right. ie what should I replace the following with?

let!(:'my_module::some_function') do
  MockFunction.new('my_module::some_function') do |f|
    f.stubbed.returns('foo')
  end
end
it do
  my_module::some_function.stubbed.returns('foo') # This line is obviously not right
  is_expected.to compile.with_all_deps
end
jeffbyrnes commented 3 years ago

This still seems to be a thing; the Puppet 4 syntax for writing a custom function isn’t covered by MockFunction.