Group Service bug

[GoogleCodeExporter]

When you grouping..

And one of your member leave your team..
they still in team.. (Not Removed)..

They must relog..

Original issue reported on code.google.com by shinji66...@yahoo.com on 13 Apr 2011 at 10:34

[GoogleCodeExporter]

Team.java

protected void removeMember(int memberId)
    {
        if(onlineMembers.contains(memberId))
        onlineMembers.remove(memberId);
        if(onlineMembers.contains(memberId))
        offlineMembers.remove(memberId);
    }

How about like this..
It's better if it check first before remove..

Becouse we have problem  not only in group but also legion..

INFO [12 Apr 2011 18:22:24,304] 
com.aionemu.commons.network.mmocore.SelectorThread:164 FAILED_RUNNING: 
com.aionemu.gameserver.network.aion.GameClient@1e8ec394
java.lang.NullPointerException
    at com.aionemu.gameserver.model.team.legion.Legion.onMemberLogOut(Legion.java:1483)
    at com.aionemu.gameserver.model.gameobjects.player.Player.onLoggedOut(Player.java:791)
    at com.aionemu.gameserver.network.aion.clientpackets.CM_ENTER_WORLD.enterWorld(CM_ENTER_WORLD.java:140)
    at com.aionemu.gameserver.network.aion.clientpackets.CM_ENTER_WORLD.runImpl(CM_ENTER_WORLD.java:115)
    at com.aionemu.commons.network.mmocore.ReceivablePacket.run(ReceivablePacket.java:75)
    at com.aionemu.commons.utils.concurrent.ExecuteWrapper.execute(ExecuteWrapper.java:61)
    at com.aionemu.commons.utils.concurrent.ExecuteWrapper.run(ExecuteWrapper.java:42)
    at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
    at java.lang.Thread.run(Unknown Source)

Original comment by shinji66...@yahoo.com on 13 Apr 2011 at 10:42

[GoogleCodeExporter]

This issue was closed by revision r553.

Original comment by mr.pok...@gmail.com on 13 Apr 2011 at 4:10

• Changed state: Fixed

[GoogleCodeExporter]

This issue was closed by revision r554.

Original comment by mr.pok...@gmail.com on 13 Apr 2011 at 4:10