Fixes #7 - Githubissues

AceCentre / FaceCommander

Control your computer by making faces

Apache License 2.0

2 stars 1 forks source link

Fixes #7 #24

Closed gavinhenderson closed 2 months ago

gavinhenderson commented 3 months ago

Hey @sjjhsjjh

I've made some minor tweaks:

I split the 'check' job into two smaller steps. One is 'GetVersion' and the other is 'RuffCheck'. Just makes it slightly clearer if a step ever fails we know what it was specifically doing. The release version is dependent on them both.
I set the release to be 'draft'. My thinking is that we will release a draft then when we manually sign it we can publish it fully.
Delete outdated workflow

Besides that im happy to merge as long as you are happy with my changes?

sjjhsjjh commented 3 months ago

Hi Gavin, I think I preferred Prerelease to Draft. The reason is that Draft releases aren't even visible to the public. That means they can't be discovered through the unauthenticated API, which the app uses now. Ace Centre could remove the Prerelease flag when the signed assets are uploaded.

gavinhenderson commented 3 months ago

@sjjhsjjh ah yeah you are totally right, I hadn't realised pre-release was on. I've undone my commit! You happy if I merge this now and we can just do a seperate PR commit for the docs? (or if its just MD files feel free to work on master)

sjjhsjjh commented 3 months ago

Sounds good. I'll aim to have the developer docco done by the end of the week and will raise another PR on the same branch at that time.

sjjhsjjh commented 3 months ago

Hi @gavinhenderson , One of the checks failed. I think it's because the merge to main counts as a commit of the Version.ini file, which kicks off a release build. That fails because the tag, which is based on the version number, already exists. You can merge anyway, or remove the tag, or see about modifying the YAML so it only picks up non-merge commits I think.