AceCentre / pasco

Phrase Auditory Scanning COmmunicator - AAC App for iOS and the Web
https://app.pasco.chat
GNU General Public License v3.0
14 stars 6 forks source link

Allow user to attach specific settings to different trees #109

Closed willwade closed 1 year ago

willwade commented 6 years ago

Use case:

Right now the solution is to use recorded messages for output - but maybe the answer is somehow storing settings in the language tree (or a connected file).

hosseinzoda commented 6 years ago

Yes. I like the idea of storing or overriding settings within tree root meta tag.

willwade commented 6 years ago

would you have this as a meta-data or as some kind of comment?

hosseinzoda commented 5 years ago

@willwade I suppose selection of speaker voice is not implemented well. We need to add locale to it.

And then within the tree locale will selected based on

  1. select locale per node cue/main
  2. select locale for all cue/main

Something like this.

<meta data-cue-locale="ar"> <!-- meta at root would override default locale for all cue voices -->
- Say Hello <meta data-locale="es"> <!-- this will select `es` lang of cue and main for "Say Hello" -->
- Option 2 <meta data-main-locale="en-GB"> <!-- this will select `en` locale for cue voice for "Option 2" -->

Then voice selection at config would be per locale.

willwade commented 5 years ago

That sounds sensible. We may need more than locale though.. We may need either a name of the voice or some other identifier. I'm trying to track down all TTS voice details (https://docs.google.com/spreadsheets/d/17A8tos9-ARWjTrYCz-41C2yz9Ki7G4RtpTMLdOy-OUc/edit?usp=sharing) with locales etc. (The ones in Apples TTS is all from Acapella I understand)

hosseinzoda commented 5 years ago

Yes. We can have locale and identifier per locale defined within the tree.

For example. UK voices have two speakers, male and female.

I can reorganize voice selection to fit this new design.

hosseinzoda commented 5 years ago

At the moment i did implement use of locale per node and #122. Which provides tools for this issue. I did ignore ability to change config within a tree. It adds complexity. But i can see there's need for changing config for each tree. (graphical interface would be best for users). @willwade What do you think?

willwade commented 5 years ago

Yes - there is a need - I get your point though re: complexity and putting into the GUI. The problem is that for end users who actually use the app - they won't be able to access the config screens etc.. So they will need some way of switching. Maybe this needs more thought. Maybe we should/could create a way of loading config files e.g..

It would then change the config settings in the config page.. Maybe????

Don't rush to do this - we can leave it if this needs more thought

gavinhenderson commented 1 year ago

@willwade I think this issue has been solved now that we can change the locales of trees? Feel free to re-open if you disagree