search

AceCentre / pasco

Phrase Auditory Scanning COmmunicator - AAC App for iOS and the Web
https://app.pasco.chat
GNU General Public License v3.0
14 stars 6 forks source link

#164 & #147 + bugfix #181

Closed hosseinzoda closed 4 years ago

hosseinzoda commented 4 years ago

stayinbranch for all helper + meta-endit

  1. A new checkbox in helper section to toggle stay-in-branch for all nodes other than root node.

  2. Use of <meta data-select-utterance> will result in a node to explicitly end the process and select that node.

    word prediction meta predict-after-n-chars #147 + bugfix

  3. Adding meta predict-after-n-chars="number" to any predict dynnode will not show any suggestions until supplied number of chars has been selected.

  4. Add missing code for flexbox layout change. '.children-wrp'.

  5. A bugfix related to back helper option at beginning. It was showing the back option after suggestions (not at beginning). By using tree_insert_node instead of tree_add_node it accounts for dynnode's with empty elements when inserting a new node.

willwade commented 4 years ago

Great. Can you clarify..

We now have a global setting - Yay! But what are all the meta-data tags..

Are these right? Any others? I just want to make sure we aren't replicating something here - or clashing with anything.

Otherwise seems to work great :)

hosseinzoda commented 4 years ago

Great. Can you clarify..

We now have a global setting - Yay!

I'm not sure what do you mean here.

But what are all the meta-data tags..

Are these right? Any others? I just want to make sure we aren't replicating something here - or clashing with anything.

Two meta data is added in this commit.

  1. <meta data-endit> This meta is useful in case you want to explicitly select a leaf node while stayinbranch is selected on one of Its parent. It acts like data-spell-finish.
  2. For two <meta data-dyn="... prediction that we have. If one adds data-predict-after-n-chars="3". It won't show any prediction until 3 characters has selected.

Otherwise seems to work great :)

willwade commented 4 years ago

“I’m not sure what do you mean” - just saying it looks good!

So do you think we should deprecate data-spell-finish? Just worried we are adding loads of data- functions that do the thing. Or do they work differently?

hosseinzoda commented 4 years ago

“I’m not sure what do you mean” - just saying it looks good!

So do you think we should deprecate data-spell-finish? Just worried we are adding loads of data- functions that do the thing. Or do they work differently?

Yeah. We can do that. I wasn't able to come up with a good name for data-endit. data-finish is confusing. Yeah. Maybe deprecating spell-finish is good.

willwade commented 4 years ago

data-exit-branch ?

hosseinzoda commented 4 years ago

I'm not sure. The process doesn't have a name. Let's call it communication session. Then maybe. data-end-session would be good.

hosseinzoda commented 4 years ago

Or communication attempt, How about data-select?

hosseinzoda commented 4 years ago

how about select-utterance?

hosseinzoda commented 4 years ago

data-endit will actually select that node. Meaning cue voice is going get uttered. So In my opinion. select-utterance is best. And maybe we have to keep data-spell-finish.

willwade commented 4 years ago

Ok. Agreed :)

willwade commented 4 years ago

Just realised my comment had the meta data commands hidden..

So to clarify, we have

<meta data-stay-in-branch>

<meta data-back-n-branch="1" data-back-n-branch-notify>

<meta data-select-utterance>

Is there any others (related to staying in a branch)?

hosseinzoda commented 4 years ago

Just realised my comment had the meta data commands hidden..

So to clarify, we have

<meta data-stay-in-branch>

<meta data-back-n-branch="1" data-back-n-branch-notify>

<meta data-select-utterance>

Is there any others (related to staying in a branch)?

Right, I think so.

willwade commented 4 years ago

Think found some others..

data-onselect-continue-in-branch data-onselect-continue-concat

is that data-onselect-continue-in-branch different?

hosseinzoda commented 4 years ago

Think found some others..

data-onselect-continue-in-branch data-onselect-continue-concat

is that data-onselect-continue-in-branch different?

Are these have implemented? I looked at main.js I can't find them.

willwade commented 4 years ago

Think found some others.. data-onselect-continue-in-branch data-onselect-continue-concat is that data-onselect-continue-in-branch different?

Are these actually implemented? I looked at main.js I can't find them.

Maybe not! Found in: https://raw.githubusercontent.com/AceCentre/pasco/master/html/trees/Spell_by_blocks_in_frequency/en-GB-Spell_by_blocks_in_frequency.md

hosseinzoda commented 4 years ago

I see, I did replace them with data-spell.....

willwade commented 4 years ago

Can you do me a favour - on this PR - can you update those html/trees and fix those clearly not working data commands? (Only I'll forget in a days time..!)