Closed hosseinzoda closed 4 years ago
Great. Can you clarify..
We now have a global setting - Yay! But what are all the meta-data tags..
Are these right? Any others? I just want to make sure we aren't replicating something here - or clashing with anything.
Otherwise seems to work great :)
Great. Can you clarify..
We now have a global setting - Yay!
I'm not sure what do you mean here.
But what are all the meta-data tags..
Are these right? Any others? I just want to make sure we aren't replicating something here - or clashing with anything.
Two meta data is added in this commit.
<meta data-endit>
This meta is useful in case you want to explicitly select a leaf node while stayinbranch is selected on one of Its parent. It acts like data-spell-finish
.<meta data-dyn="...
prediction that we have. If one adds data-predict-after-n-chars="3"
. It won't show any prediction until 3 characters has selected.Otherwise seems to work great :)
“I’m not sure what do you mean” - just saying it looks good!
So do you think we should deprecate data-spell-finish? Just worried we are adding loads of data- functions that do the thing. Or do they work differently?
“I’m not sure what do you mean” - just saying it looks good!
So do you think we should deprecate data-spell-finish? Just worried we are adding loads of data- functions that do the thing. Or do they work differently?
Yeah. We can do that. I wasn't able to come up with a good name for data-endit
. data-finish
is confusing. Yeah. Maybe deprecating spell-finish is good.
data-exit-branch ?
I'm not sure. The process doesn't have a name. Let's call it communication session. Then maybe. data-end-session
would be good.
Or communication attempt, How about data-select
?
how about select-utterance
?
data-endit
will actually select that node. Meaning cue voice is going get uttered. So In my opinion. select-utterance
is best. And maybe we have to keep data-spell-finish.
Ok. Agreed :)
Just realised my comment had the meta data commands hidden..
So to clarify, we have
<meta data-stay-in-branch>
<meta data-back-n-branch="1" data-back-n-branch-notify>
<meta data-select-utterance>
Is there any others (related to staying in a branch)?
Just realised my comment had the meta data commands hidden..
So to clarify, we have
<meta data-stay-in-branch>
<meta data-back-n-branch="1" data-back-n-branch-notify>
<meta data-select-utterance>
Is there any others (related to staying in a branch)?
Right, I think so.
Think found some others..
data-onselect-continue-in-branch data-onselect-continue-concat
is that data-onselect-continue-in-branch
different?
Think found some others..
data-onselect-continue-in-branch data-onselect-continue-concat
is that
data-onselect-continue-in-branch
different?
Are these have implemented? I looked at main.js
I can't find them.
Think found some others..
data-onselect-continue-in-branch data-onselect-continue-concat
is thatdata-onselect-continue-in-branch
different?Are these actually implemented? I looked at
main.js
I can't find them.
Maybe not! Found in: https://raw.githubusercontent.com/AceCentre/pasco/master/html/trees/Spell_by_blocks_in_frequency/en-GB-Spell_by_blocks_in_frequency.md
I see, I did replace them with data-spell....
.
Can you do me a favour - on this PR - can you update those html/trees and fix those clearly not working data commands? (Only I'll forget in a days time..!)
stayinbranch for all helper + meta-endit
A new checkbox in helper section to toggle stay-in-branch for all nodes other than root node.
Use of
<meta data-select-utterance>
will result in a node to explicitly end the process and select that node.word prediction meta predict-after-n-chars #147 + bugfix
Adding meta
predict-after-n-chars="number"
to any predict dynnode will not show any suggestions until supplied number of chars has been selected.Add missing code for flexbox layout change. '.children-wrp'.
A bugfix related to back helper option at beginning. It was showing the back option after suggestions (not at beginning). By using
tree_insert_node
instead oftree_add_node
it accounts for dynnode's with empty elements when inserting a new node.