search

AceCentre / pasco

Phrase Auditory Scanning COmmunicator - AAC App for iOS and the Web
https://app.pasco.chat
GNU General Public License v3.0
14 stars 6 forks source link

Move "Display message bar when spelling" to Appearance #208

Closed willwade closed 4 years ago

willwade commented 4 years ago

Feels more accurate putting that in appearance than in helpers

willwade commented 4 years ago

Not sure if we have introduced this bug - but Message bar now displays even if "Display message bar when spelling" is not checked

willwade commented 4 years ago

See video: https://www.dropbox.com/s/tufdllbnmojs0vr/Screen%20Recording%202020-03-31%20at%2009.25.33.mov?dl=0

Some probs:

  1. Watch how I tap UP and it rightly goes to the bottom of the list. I tap up again and it gets stuck (I was trying to get to undo)

See video 2: https://www.dropbox.com/s/tancl09u7s5mwe0/Screen%20Recording%202020-03-31%20at%2009.30.06.mov?dl=0

  1. So after selecting a prediction I was expecting "Control" to end with a space - and it then restart. But it doesnt. I need to enter a space manually
  2. Notice how I repeatedly tap down - and it actually then hangs

Not sure how big a problem this is - but in the logs I see:

2020-03-31 09:25:11.879543+0100 pasco[2173:2358630] WARN: Could not load trees_info file, cdvfile://localhost/persistent/trees-info.json Error: Fail to load `cdvfile://localhost/persistent/trees-info.json` -- 1 (maybe not related)

hosseinzoda commented 4 years ago

@willwade I've recently pushed a new commit. Which did fix a problem like that for me. Please check if it does fix these issues.

willwade commented 4 years ago

I think its still there.. https://www.dropbox.com/s/kxh8jdzdi6f4c9k/Screen%20Recording%202020-04-01%20at%2009.04.32.mov?dl=0

willwade commented 4 years ago

Ok - all fixed. Just one small thing outstanding..

Is it possible under "Message Bar height" to have "Font Size for Message bar" - % slider?

To be clear - I'm not sure if this is best done as a % change - basically need to change the font height - but maybe best done as a theme thing - and not sure what happens to lines or line height and spacing.. Maybe % change will do it.