search

AceCentre / pasco

Phrase Auditory Scanning COmmunicator - AAC App for iOS and the Web
https://app.pasco.chat
GNU General Public License v3.0
14 stars 6 forks source link

[WIP] Webpack Migration #226

Closed gavinhenderson closed 3 years ago

gavinhenderson commented 4 years ago

Pages Migrated

New NPM scripts:

webpack:dev - Runs webpack-dev-server and opens app in the browser webpack:build - Builds the webpack app to the dist folder webpack:cordova-dev - Opens a simulator and runs the webpack app in it (includes hot reloading) webpack:cordova-build - Builds the webpack app into the cordova folder

test - Runs jest tests test:watch - Runs the tests in watch mode test:coverage - Outputs the test coverage

Config

There is a webpack folder that contains all the config files for webpack. HtmlWebpackPlugin is used to copy the HTML pages into the build and then we give each file one chunk. It might make sense eventually to have a main chunk and include that in all pages.

How to help

Start migrating a page and submit a PR. I will make sure to keep this branch up to date with master, so if you make improvements to the master ill make sure they end up on this branch.

Another great way to contribute would be to add some tests! 👍

Any questions or comments dont hesitate to reach out :)

gavinhenderson commented 4 years ago

Hey @willwade and @hosseinamin I was wondering if you could give me a hand with a few quick questions. Why is there a different help file for 'es-ES' locale but no other locale, and why is it in english? Is this something we still need?

Also how much of a focus is internationalisation of the project? It seems to add a lot of complexity to the codebase and if no one needs it I would suggest we leave it out of the migration?

willwade commented 4 years ago

Great question. That es help file shouldn’t have been committed. It what led to a general discussion that we may want to rethink how we do the locale stuff - at least for the help pages. L10n is fairly important in that we have had to support people who are not English speaking - as carers or the direct user. The whole bi lingual (cue in one language - and output in another) makes pasco pretty unique. But saying that - it’s probably not being used that much at this stage (We currently have two users who speak a second language but granted are using the English locale). If it’s hellish then I can go with leaving it out but would be good to think how it should be done. See also https://github.com/AceCentre/pasco/issues/102 and https://github.com/AceCentre/pasco/issues/104

gavinhenderson commented 4 years ago

@willwade Perfect, ill pull that out :) Im happy to leave the l10n stuff in, just wanted to make sure that it had some value and sounds like it has lots!

gavinhenderson commented 3 years ago

Going to close this.

It was to ambitious. Whatever we do we will need to do it incrementally and not big bang. The code is still accessible for inspiration