search

AceCentre / pasco

Phrase Auditory Scanning COmmunicator - AAC App for iOS and the Web
https://app.pasco.chat
GNU General Public License v3.0
14 stars 6 forks source link

Improve prediction by doing case-insensitive search #230

Closed sylvansson closed 4 years ago

sylvansson commented 4 years ago

We currently do a case-sensitive search when we do prediction, which is a problem because we won't find certain words like "Kelly" after typing k-e-l. This PR updates the search to be case-insensitive, and refactors some of the prediction logic for clarity.

Close #219

sylvansson commented 4 years ago

@willwade I did some QA (for the web version only), but I suggest you do the same as I'm not familiar with this project yet.

willwade commented 4 years ago

Awesome. Thank you. The case sensitive thing explains things!

willwade commented 4 years ago

Thanks @sylvansson - looks good here (nb - re: testing on the web. Be aware of this bug https://github.com/AceCentre/pasco/issues/217 )

sylvansson commented 4 years ago

I encountered #217 too. I'll look into it.