AceCentre / pasco

Phrase Auditory Scanning COmmunicator - AAC App for iOS and the Web

https://app.pasco.chat

GNU General Public License v3.0

14 stars 6 forks source link

Update gulp + gulp-sass & edit-config performance improvements #274

Closed hosseinzoda closed 2 years ago

hosseinzoda commented 2 years ago

In this PR I went ahead and updated the gulp module since it wasn't building on nodejs 17.

Issue #269 should be fixed with the performance improvements of this PR. edit-config page was having a hard time initializing the page. This is caused mainly by use of rangeslider-js module.

There are some minor bugfixes and typo fixes as well.

gavinhenderson commented 2 years ago

since it wasn't building on nodejs 17.

Can we target either node 16 or 18? 17 isn't an LTS (long term support) version so its best to avoid it.

hosseinzoda commented 2 years ago

since it wasn't building on nodejs 17.

Can we target either node 16 or 18? 17 isn't an LTS (long term support) version so its best to avoid it.

Node v17 was not my main concern. But it was the cause for the error. gulp-sass needed update. node-sass module is no longer being maintained and it is replaced with sass module. That was the primary change I've made in that commit.

gavinhenderson commented 2 years ago

@hosseinamin After testing #269 still seems like an issue. It crashes at the same point.

Its worth noting it crashes when you come out of the settings page and the normal vocab/tree page loads.

I can record a video if you need to see how to reproduce the error?

hosseinzoda commented 2 years ago

PR #268 has been added in this PR. And surprisingly the error message does not show up in this merge.

269 bug is also fixed with the last few commits.