search

AceLikesGhosts / ytm-rpc

a poorly made youtube music rpc
MIT License
1 stars 0 forks source link

rewrite(server): Rewrite server to TypeScript #12

Closed AceLikesGhosts closed 1 year ago

AceLikesGhosts commented 1 year ago

Beginning stages for #10 and #11

11 will be completed once this PR is merged, as then we will have an easily extendable Server setup.

What this PR does:

  1. Changes from a single file server to a modular server setup, so that we are in the future able to have both an RPC-express server and a BetterDiscord plugin which will communicate with WebSockets
  2. Rewrites the project in Typescript, adding type safety and making the project not so.. ugly
  3. Hopefully will bring more clarity as to what does what, with more distinct files, and not having everything in a singular file
  4. Add linting to the file (@biased-ts/eslint-config)
l1mey112 commented 1 year ago

hi honey

AceLikesGhosts commented 1 year ago

hi honey

hi, source code review when? im rusty @ TS i gotta make sure im doing all the things the cool kids do for it (i even threw in eslint!! :o)

AceLikesGhosts commented 1 year ago

This is ready to merge but I'm going to wait for LM's review (: image

AceLikesGhosts commented 1 year ago

bro basically "LGTM"'d with no actual review notes 😭

l1mey112 commented 1 year ago

bro basically "LGTM"'d with no actual review notes 😭

because it does look good to me

AceLikesGhosts commented 1 year ago

bro basically "LGTM"'d with no actual review notes 😭

because it does look good to me

this project is void abuse