search

AceMetrix / bower-license

Generates a list of bower dependencies
Apache License 2.0
15 stars 29 forks source link

Enable to change component directory #4

Closed ymstmsys closed 9 years ago

ymstmsys commented 9 years ago

'options.directory' parameter seems to be ignored wrongly. In order to enable to change component directory, I modified this problem.

mojoaxel commented 9 years ago

Thx! This makes sense!

ymstmsys commented 9 years ago

Thx, I improved code. Additionally, I added '--directory' option and prioritized user options over '.bowerrc'.

anacronw commented 9 years ago

Actually, I think if you just swapped the options such that:

options = _.extend({}, options, {directory: 'bower_components'})

becomes

options = _.extend({}, {directory: 'bower_components'}, options)

It does most of what you're trying to achieve. Ultimately, I don't see a use case for the user customizing their directory, however. Shouldn't the directory be specified by their .bowerrc file?

anacronw commented 9 years ago

Didn't see the date! Boy was I late on the reply :)

I will go ahead and fix the bug - thanks for reporting it. I'm still open to pulling in the --directory option if it makes sense.