search

AceTheEldritchKing / Secrets-Of-Forging-Revelations

2 stars 2 forks source link

Modular polearms can't be gilded #1

Closed AlbusRex closed 1 year ago

AlbusRex commented 1 year ago

The title is pretty clear, it is not possible to gild a modular polearm.

image

Version

Using latest available versions for Tetra, AoF and SoFR for forge 1.19.2

Steps to reproduce:

  1. Craft an iron spear or any other modular polearm.
  2. Hone the modular polearm manually or with the tetra command.
  3. Place a workstation, a gilding scroll on top of said workstation and a have hammer on the inventory.
  4. Observe that gilding is not on the honing upgrades list, like in the provided picture.

Observations

With my very limited knowledge I attempted to diagnose the issue, and I think it might have something to do with modular polearms not being in the list of items that 'data/tetra/improvements/shared' applies to from Tetra itself. This list includes the gilding improvement among others. I hope this issue has all the relevant information to fix this and thank you for maintaining this excelent mod.

AlbusRex commented 1 year ago

I have figured out a fix for this issue, there is an open PR with the fix I made.

AceTheEldritchKing commented 1 year ago

Hi! I already found the issue and fixed it on the main branch. The fix will be available next update, as right now there are other additions in the main branch that haven't been pushed as well.

AlbusRex commented 1 year ago

I see, I will mark this issue as closed and cancel the PR as well since there is a confirmed fix. I am looking forward to the next update :)